Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 864663003: These test will now pass with subpixel fix for scrollX, scrollY (Closed)

Created:
5 years, 10 months ago by terry
Modified:
5 years, 10 months ago
Reviewers:
vsm, siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

These test will now pass with subpixel fix for scrollX, scrollY Re-gen'd SDK with new Window.idl (double scrollX, scrollY, pageXOffset and pageYOffset). Reviewers=vsm@google.com,asiva@google.com R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=43480

Patch Set 1 #

Patch Set 2 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/co19/co19-dartium.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/html/html.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
terry
5 years, 10 months ago (2015-02-04 18:01:10 UTC) #2
siva
lgtm
5 years, 10 months ago (2015-02-04 18:05:04 UTC) #3
terry
5 years, 10 months ago (2015-02-04 18:06:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43480 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698