Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 864643006: Allow sync *, async * and yield * in dart2js (Closed)

Created:
5 years, 10 months ago by Johnni Winther
Modified:
5 years, 10 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Allow sync *, async * and yield * in dart2js BUG=http://dartbug.com/22234 R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=43593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -35 lines) Patch
M pkg/compiler/lib/src/scanner/parser.dart View 4 chunks +0 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/async_await_syntax_test.dart View 1 chunk +9 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +4 lines, -1 line 0 comments Download
M tests/compiler/dart2js/frontend_checker.dart View 5 chunks +47 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 10 months ago (2015-02-09 12:02:23 UTC) #2
sigurdm
LGTM Please mention the relevant bug in the description
5 years, 10 months ago (2015-02-09 13:08:00 UTC) #3
Johnni Winther
5 years, 10 months ago (2015-02-09 14:26:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43593 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698