Support code generation for other languages

Support code generation for other languages

R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43144

[Brian Wilkerson, 2015-01-23 19:16:59]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com

[Brian Wilkerson, 2015-01-23 19:17:00]

These changes were submitted by Guillermo, but he was having trouble with
gclient and couldn't submit a CL because of it.

[Paul Berry, 2015-01-23 19:28:59]

lgtm.  I have two minor comments below, but I don't feel terribly strongly about
either of them.

https://codereview.chromium.org/863883004/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/codegen_tools.dart (right):

https://codereview.chromium.org/863883004/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/codegen_tools.dart:58: // Defaults are good for
generating Java and Dart source code.
It's a little confusing to call this "defaults" since the settings can be
changed, and after they are changed, they won't be the default settings anymore
:)

How about this comment instead:

"Settings that specialize code generation behavior for a given programming
language"

Also, the comment should use Javadoc notation so that it will be picked up by
dartdoc.

https://codereview.chromium.org/863883004/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/codegen_tools.dart:67: * Change code generation
settings to adapt [CodeGenerator] to any
Since we're allowing the client to change the settings arbitrarily, I'd prefer
to just remove this setter and rename "_settings" to some public name (e.g.
"codeGeneratorSettings").

[guillermooo, 2015-01-23 19:49:12]

guillermo.listas@gmail.com changed reviewers:
+ guillermo.listas@gmail.com

[guillermooo, 2015-01-23 19:49:13]

https://codereview.chromium.org/863883004/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/codegen_tools.dart (right):

https://codereview.chromium.org/863883004/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/codegen_tools.dart:58: // Defaults are good for
generating Java and Dart source code.
On 2015/01/23 19:28:59, Paul Berry wrote:
> It's a little confusing to call this "defaults" since the settings can be
> changed, and after they are changed, they won't be the default settings
anymore
> :)
> 
> How about this comment instead:
> 
> "Settings that specialize code generation behavior for a given programming
> language"
> 
> Also, the comment should use Javadoc notation so that it will be picked up by
> dartdoc.

Acknowledged.

https://codereview.chromium.org/863883004/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/codegen_tools.dart:67: * Change code generation
settings to adapt [CodeGenerator] to any
On 2015/01/23 19:28:59, Paul Berry wrote:
> Since we're allowing the client to change the settings arbitrarily, I'd prefer
> to just remove this setter and rename "_settings" to some public name (e.g.
> "codeGeneratorSettings").

Acknowledged.

https://codereview.chromium.org/863883004/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/codegen_tools.dart:451: String docCommentStart;
Rename to docCommentStartMarker?

https://codereview.chromium.org/863883004/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/codegen_tools.dart:461: String docCommentEnd;
Rename to docCommentEndMarker?

https://codereview.chromium.org/863883004/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/codegen_tools.dart:466: int commentLineLength;
Should we have a `commentLineLength` and `docCommentLineLength`?

[Brian Wilkerson, 2015-01-26 19:35:59]

Committed patchset #3 (id:40001) manually as 43144 (presubmit successful).

[guillermooo, 2015-01-26 20:22:14]

On 2015/01/26 19:35:59, Brian Wilkerson wrote:
> Committed patchset #3 (id:40001) manually as 43144 (presubmit successful).

\o/

My first patch for the Dart codebase! :)