Issue 863773002: Revert "Mark all private functions in dart: libraries as invisible (*sniff*). Previously these func…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 863773002: Revert "Mark all private functions in dart: libraries as invisible (sniff). Previously these func… (Closed)

Created:
5 years, 11 months ago by rmacnak

Modified:
5 years, 11 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Revert "Mark all private functions in dart: libraries as invisible (*sniff*). Previously these functions were only marked invisible if they were also native, a constructor, or on a black list." Broke Dartium. TBR=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=43026

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+189 lines, -85 lines)			Patch
M	runtime/bin/filter_patch.dart	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	runtime/bin/io_service_patch.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/socket_patch.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/lib/mirrors.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/lib/mirrors.cc	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+93 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	6 chunks	+12 lines, -16 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/io_patch.dart	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	sdk/lib/io/data_transformer.dart	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	sdk/lib/io/directory_impl.dart	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	9 chunks	+9 lines, -9 lines	0 comments	Download
M	sdk/lib/io/file_system_entity.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/io/io_service.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/link.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/io/secure_socket.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/mirrors/invocation_fuzz_test.dart	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages

Issue 863773002: Revert "Mark all private functions in dart: libraries as invisible (*sniff*). Previously these func… (Closed)

Description

Patch Set 1 #

Messages

Issue 863773002: Revert "Mark all private functions in dart: libraries as invisible (sniff). Previously these func… (Closed)