Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 863473002: Make server more resilient. (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, Johnni Winther, lukechurch
Target Ref:
refs/remotes/trunk
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -37 lines) Patch
M dart/pkg/dart2js_incremental/lib/server.dart View 6 chunks +55 lines, -37 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
ahe
I've learned how to program with futures since I wrote the original code.
5 years, 11 months ago (2015-01-19 12:14:09 UTC) #2
kasperl
LGTM! https://codereview.chromium.org/863473002/diff/1/dart/pkg/dart2js_incremental/lib/server.dart File dart/pkg/dart2js_incremental/lib/server.dart (right): https://codereview.chromium.org/863473002/diff/1/dart/pkg/dart2js_incremental/lib/server.dart#newcode105 dart/pkg/dart2js_incremental/lib/server.dart:105: return f.exists().then((bool exists) { Maybe use await and ...
5 years, 11 months ago (2015-01-19 12:24:44 UTC) #3
ahe
Committed patchset #1 (id:1) manually as 42987 (presubmit successful).
5 years, 11 months ago (2015-01-19 12:50:31 UTC) #4
ahe
5 years, 11 months ago (2015-01-19 12:58:01 UTC) #5
Message was sent while issue was closed.
Thank you, Kasper!

https://codereview.chromium.org/863473002/diff/1/dart/pkg/dart2js_incremental...
File dart/pkg/dart2js_incremental/lib/server.dart (right):

https://codereview.chromium.org/863473002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/server.dart:105: return f.exists().then((bool
exists) {
On 2015/01/19 12:24:44, kasperl wrote:
> Maybe use await and mark the method async?
> 
> bool exists = await f.exists();
> ...

Next CL.

Powered by Google App Engine
This is Rietveld 408576698