Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 863353002: dart2js: Don't add properties to native classes that are not needed. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Don't add properties to native classes that are not needed. This has no impact on the output, and almost no impact on the compilation time. However, it makes it clearer, that unneeded native classes really are not needed, and don't need their nativeSpecProperty either. I want to refactor this code in another CL, but I think it's cleaner if this if-check is already in place now, and not merged into a bigger change. R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=43096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 11 months ago (2015-01-22 17:14:48 UTC) #2
sra1
lgtm
5 years, 11 months ago (2015-01-22 17:30:31 UTC) #3
floitsch
5 years, 11 months ago (2015-01-23 10:35:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43096 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698