Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 862783002: dart2js: Fix getter/setter flags in the model. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
zarah, herhut
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Fix getter/setter flags in the model. It was inverting cases 10 and 11. Here is the relevant part from model.dart: /// 00: Does not need any getter. /// 01: function() { return this.field; } /// 10: function(receiver) { return receiver.field; } /// 11: function(receiver) { return this.field; } final int getterFlags; /// 00: Does not need any setter. /// 01: function(value) { this.field = value; } /// 10: function(receiver, value) { receiver.field = value; } /// 11: function(receiver, value) { this.field = value; } final int setterFlags; R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
5 years, 11 months ago (2015-01-20 22:11:50 UTC) #2
floitsch
ping
5 years, 11 months ago (2015-01-22 15:51:56 UTC) #4
zarah
LGTM
5 years, 11 months ago (2015-01-22 19:29:43 UTC) #5
floitsch
5 years, 11 months ago (2015-01-23 10:34:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43095 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698