Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 862093003: Reapply "Mark all private functions in dart: libraries as invisible (*sniff*). Previously these fun… (Closed)

Created:
5 years, 11 months ago by rmacnak
Modified:
5 years, 11 months ago
Reviewers:
Cutch, gbracha, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Reapply "Mark all private functions in dart: libraries as invisible (*sniff*). Previously these functions were only marked invisible if they were also native, a constructor, or on a black list." Broken assumption in Dartium fixed in blink r188698. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=43053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -189 lines) Patch
M runtime/bin/filter_patch.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M runtime/bin/io_service_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/socket_patch.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/lib/mirrors.h View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/lib/mirrors.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +0 lines, -93 lines 0 comments Download
M runtime/vm/parser.cc View 6 chunks +16 lines, -12 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/io_patch.dart View 2 chunks +10 lines, -10 lines 0 comments Download
M sdk/lib/io/data_transformer.dart View 2 chunks +10 lines, -10 lines 0 comments Download
M sdk/lib/io/directory_impl.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 9 chunks +9 lines, -9 lines 0 comments Download
M sdk/lib/io/file_system_entity.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/io/io_service.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/link.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/io/secure_socket.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/invocation_fuzz_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 11 months ago (2015-01-21 20:20:37 UTC) #2
hausner
lgtm
5 years, 11 months ago (2015-01-21 20:22:58 UTC) #3
rmacnak
5 years, 11 months ago (2015-01-21 20:44:18 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 43053 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698