Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 861893003: Library Dependencies Analysis service API. (Closed)

Created:
5 years, 11 months ago by pquitslund
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -2 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/GetLibraryDependenciesConsumer.java View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java View 1 2 4 chunks +12 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/LibraryDependenciesProcessor.java View 1 2 3 1 chunk +47 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/MockAnalysisServer.java View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 1 2 3 2 chunks +86 lines, -0 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 1 2 2 chunks +23 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 2 3 chunks +11 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 1 2 1 chunk +88 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart View 1 2 1 chunk +44 lines, -0 lines 6 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
pquitslund
5 years, 11 months ago (2015-01-21 00:54:36 UTC) #2
scheglov
LGTM Would be good to have a test. https://codereview.chromium.org/861893003/diff/20001/pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart File pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart (right): https://codereview.chromium.org/861893003/diff/20001/pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart#newcode11 pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart:11: String ...
5 years, 11 months ago (2015-01-21 15:10:06 UTC) #3
Brian Wilkerson
LGTM https://codereview.chromium.org/861893003/diff/20001/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/861893003/diff/20001/pkg/analysis_server/tool/spec/spec_input.html#newcode362 pkg/analysis_server/tool/spec/spec_input.html:362: <request method="getLibraryDependencies"> I do think it would be ...
5 years, 11 months ago (2015-01-22 01:45:35 UTC) #4
pquitslund
https://codereview.chromium.org/861893003/diff/20001/pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart File pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart (right): https://codereview.chromium.org/861893003/diff/20001/pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart#newcode11 pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart:11: String _getParentPath(String path) { On 2015/01/21 15:10:06, scheglov wrote: ...
5 years, 11 months ago (2015-01-22 19:22:15 UTC) #5
pquitslund
I'll add library dependency calculation tests in a follow-up CL. In the meantime, this updates ...
5 years, 11 months ago (2015-01-22 19:31:44 UTC) #6
scheglov
lgtm https://codereview.chromium.org/861893003/diff/60001/pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart File pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart (right): https://codereview.chromium.org/861893003/diff/60001/pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart#newcode4 pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart:4: Add a library name. https://codereview.chromium.org/861893003/diff/60001/pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart#newcode12 pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart:12: final Set<LibraryElement> ...
5 years, 11 months ago (2015-01-22 20:14:20 UTC) #7
pquitslund
Committed patchset #4 (id:60001) manually as r43077 (presubmit successful).
5 years, 11 months ago (2015-01-22 21:26:39 UTC) #8
jwren
On 2015/01/22 21:26:39, pquitslund wrote: > Committed patchset #4 (id:60001) manually as r43077 (presubmit successful). ...
5 years, 11 months ago (2015-01-23 19:37:27 UTC) #9
pquitslund
5 years, 11 months ago (2015-01-26 20:21:28 UTC) #10
Message was sent while issue was closed. 
Forgot to publish these...

https://codereview.chromium.org/861893003/diff/60001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart
(right):

https://codereview.chromium.org/861893003/diff/60001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart:4: 
On 2015/01/22 20:14:20, scheglov wrote:
> Add a library name.

Done.

https://codereview.chromium.org/861893003/diff/60001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart:12:
final Set<LibraryElement> myVisitedLibraries = new Set<LibraryElement>();
On 2015/01/22 20:14:20, scheglov wrote:
> Strange name ;-)
> Why not just "_visitedLibraries"?
> And we could make it private.

Done.

https://codereview.chromium.org/861893003/diff/60001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart:33:
final String path = cu.source.fullName;
On 2015/01/22 20:14:20, scheglov wrote:
> I don't think we need to make local variables private.

Done.

Powered by Google App Engine
This is Rietveld 408576698