Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 861813003: Move StartIsolateScope into MessageHandler::HandleMessages (Closed)

Created:
5 years, 11 months ago by Cutch
Modified:
5 years, 11 months ago
Reviewers:
turnidge, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Move StartIsolateScope into MessageHandler::HandleMessages R=iposva@google.com, turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=43021

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M runtime/vm/isolate.h View 1 2 chunks +8 lines, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/message_handler.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Cutch
5 years, 11 months ago (2015-01-20 18:32:07 UTC) #2
turnidge
lgtm
5 years, 11 months ago (2015-01-20 18:33:52 UTC) #3
Cutch
PTAL
5 years, 11 months ago (2015-01-20 18:48:34 UTC) #4
Ivan Posva
LGTM -ip
5 years, 11 months ago (2015-01-20 19:10:06 UTC) #5
Cutch
5 years, 11 months ago (2015-01-20 19:13:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43021 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698