Issue 861723003: Fix minified output for FunctionThatReturnsNull.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 861723003: Fix minified output for FunctionThatReturnsNull. (Closed)

Created:
5 years, 11 months ago by herhut

Modified:
5 years, 11 months ago

Reviewers:
karlklose, sigurdm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Fix minified output for FunctionThatReturnsNull. BUG= TBR=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=43002

Patch Set 1 #

Total comments: 1

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

herhut

Committed patchset #1 (id:1) manually as 43002 (presubmit successful).

5 years, 11 months ago (2015-01-20 10:17:23 UTC) #2

sigurdm

5 years, 11 months ago (2015-01-20 10:36:16 UTC) #5

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/861723003/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/861723003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:938: output.add(N);
I guess you could chose to only output this in minified mode
But it doesn't matter much.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages