Issue 86153003: attempt to reduce IE flakiness in template_bind_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 86153003: attempt to reduce IE flakiness in template_bind_test (Closed)

Created:
7 years ago by Jennifer Messerly

Modified:
7 years ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, kustermann

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

attempt to reduce IE flakiness in template_bind_test I think the issue is that IE9/10 don't have native mutation observers, so the timing of mutation observers isn't (necessarily) any faster than "new Future". What we do now is wait for the "option" to get expanded before trying to run the test. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=30646

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -16 lines)			Patch
	M	pkg/template_binding/test/template_binding_test.dart	View		1 chunk	+27 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

Thanks to Martin for tracking down this test as a source of flakiness on IE's.

7 years ago (2013-11-25 20:42:21 UTC) #1

Jennifer Messerly

7 years ago (2013-11-25 21:50:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r30646 (presubmit successful).

Expand Messages | Collapse Messages