Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 861313006: Treat add events for known files as modifications instead of discarding them on Mac OS. Fixes pub s… (Closed)

Created:
5 years, 11 months ago by Bob Nystrom
Modified:
5 years, 11 months ago
Reviewers:
nweiz, Anders Johnsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/watcher.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Treat add events for known files as modifications instead of discarding them on Mac OS. Fixes pub serve not seeing files saved in IntelliJ or other tools that use "safe" writes. https://code.google.com/p/dart/issues/detail?id=21402 R=ajohnsen@google.com, nweiz@google.com Committed: https://github.com/dart-lang/watcher/commit/74225b45b340228bcf6d3ead2b6f719eeeade924

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -7 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/directory_watcher/mac_os.dart View 1 chunk +9 lines, -6 lines 1 comment Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/directory_watcher/shared.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bob Nystrom
After this lands, I'll publish it and bring it into the repo for pub.
5 years, 11 months ago (2015-01-22 00:15:47 UTC) #2
nweiz
lgtm https://codereview.chromium.org/861313006/diff/1/lib/src/directory_watcher/mac_os.dart File lib/src/directory_watcher/mac_os.dart (right): https://codereview.chromium.org/861313006/diff/1/lib/src/directory_watcher/mac_os.dart#newcode182 lib/src/directory_watcher/mac_os.dart:182: // If we already know about the file, ...
5 years, 11 months ago (2015-01-22 00:20:19 UTC) #3
Anders Johnsen
lgtm
5 years, 11 months ago (2015-01-22 10:03:13 UTC) #4
Bob Nystrom
5 years, 11 months ago (2015-01-22 17:49:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
74225b45b340228bcf6d3ead2b6f719eeeade924 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698