glob pkg: fixed test, updated homepage url, added SDK constraint

added missing collection dependency

fixed test, updated homepage url, added SDK constraint

Committed: https://github.com/dart-lang/glob/commit/523190fa69760f48b7b64d5230da57181b06e513

[kevmoo, 2015-01-21 22:46:24]

kevmoo@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2015-01-21 22:57:40]

https://codereview.chromium.org/861313003/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/861313003/diff/1/pubspec.yaml#newcode2
pubspec.yaml:2: version: 1.0.3+1
We only use + on pre-1.0.0 packages.

https://codereview.chromium.org/861313003/diff/1/pubspec.yaml#newcode6
pubspec.yaml:6: sdk: '>=1.0.0 <2.0.0'
This isn't a useful constraint; no one's using SDK versions prior to 1.0.0
anymore.

[kevmoo, 2015-01-21 23:12:30]

Please see latest CL. Added missing collection dependency.

https://codereview.chromium.org/861313003/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/861313003/diff/1/pubspec.yaml#newcode2
pubspec.yaml:2: version: 1.0.3+1
On 2015/01/21 22:57:40, nweiz wrote:
> We only use + on pre-1.0.0 packages.

Done.

https://codereview.chromium.org/861313003/diff/1/pubspec.yaml#newcode6
pubspec.yaml:6: sdk: '>=1.0.0 <2.0.0'
On 2015/01/21 22:57:40, nweiz wrote:
> This isn't a useful constraint; no one's using SDK versions prior to 1.0.0
> anymore.

Setting the upper bound to Dart 2.0.0 IS useful, though.

Happy to take your recommendation on a good lower bound.

[nweiz, 2015-01-22 00:12:58]

https://codereview.chromium.org/861313003/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/861313003/diff/1/pubspec.yaml#newcode6
pubspec.yaml:6: sdk: '>=1.0.0 <2.0.0'
On 2015/01/21 23:12:30, kevmoo wrote:
> On 2015/01/21 22:57:40, nweiz wrote:
> > This isn't a useful constraint; no one's using SDK versions prior to 1.0.0
> > anymore.
> 
> Setting the upper bound to Dart 2.0.0 IS useful, though.
> 
> Happy to take your recommendation on a good lower bound.

Most packages don't specify an SDK upper bound, which means that when Dart 2.0.0
actually comes out we'll probably just have pub refuse any packages without an
explicit SDK constraint anyway.

https://codereview.chromium.org/861313003/diff/20001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/861313003/diff/20001/CHANGELOG.md#newcode3
CHANGELOG.md:3: * Added overllooked `collection` dependency.
"overlooked"

[kevmoo, 2015-01-22 00:24:20]

Committed patchset #3 (id:40001) manually as
523190fa69760f48b7b64d5230da57181b06e513 (presubmit successful).