Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 861033005: Consistent treatment of allocation failures in old space. (Closed)

Created:
5 years, 11 months ago by koda
Modified:
5 years, 11 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Consistent treatment of allocation failures in old space. On OS page allocation failure, try GC, and throw OOM. This will be exercised more often now that there is no default hard limit. (However, writing a reliable unit test for this path is tricky.) R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=43122

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M runtime/vm/pages.cc View 4 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
5 years, 11 months ago (2015-01-23 18:42:53 UTC) #1
Ivan Posva
LGTM -ip
5 years, 11 months ago (2015-01-23 19:10:16 UTC) #2
koda
5 years, 11 months ago (2015-01-23 21:29:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r43122 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698