Issue 860903002: Invalidate parsing information when a file is added.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 860903002: Invalidate parsing information when a file is added. (Closed)

Created:
5 years, 11 months ago by scheglov

Modified:
5 years, 11 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Invalidate parsing information when a file is added. We resolve directives URIs during parse, so if a referenced file was added after parsing, it may fix some "Unresolved URI" problems. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=22101 Committed: https://code.google.com/p/dart/source/detail?r=43030

Patch Set 1 #

Total comments: 2

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -2 lines)			Patch
	M	pkg/analyzer/lib/src/generated/engine.dart	View		3 chunks	+25 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/860903002/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/860903002/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode9182 pkg/analyzer/lib/src/generated/engine.dart:9182: setState(RESOLVED_UNIT, CacheState.INVALID); I would have expected the RESOLVED_UNIT ...

5 years, 11 months ago (2015-01-20 21:32:05 UTC) #2

scheglov

Committed patchset #1 (id:1) manually as 43030 (presubmit successful).

5 years, 11 months ago (2015-01-20 23:12:02 UTC) #3

scheglov

5 years, 11 months ago (2015-01-20 23:12:29 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/860903002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/860903002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/engine.dart:9182: setState(RESOLVED_UNIT,
CacheState.INVALID);
On 2015/01/20 21:32:04, Brian Wilkerson wrote:
> I would have expected the RESOLVED_UNIT to get invalidated by
> invalidateAllResolutionInformation.

Done.

Expand Messages | Collapse Messages