Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 86073004: Issue 14868. Show both errors/warnings and Dart doc. (Closed)

Created:
7 years ago by scheglov
Modified:
7 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartTextHover.java View 4 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
7 years ago (2013-11-25 20:12:08 UTC) #1
lukechurch
Please can you send me a screenshot
7 years ago (2013-11-25 20:13:40 UTC) #2
Brian Wilkerson
The code changes LGTM, assuming that this is what we want in the UI.
7 years ago (2013-11-25 20:51:17 UTC) #3
scheglov
7 years ago (2013-11-25 23:53:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r30652 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698