Issue 859943005: Fix 64-bit bug in optimized class-check instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 859943005: Fix 64-bit bug in optimized class-check instructions. (Closed)

Created:
5 years, 11 months ago by Florian Schneider

Modified:
5 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix 64-bit bug in optimized class-check instructions. The mask is machine-word wide, so the computation of the mask must not use a 32-bit shift operation. BUG=dartbug.com/22104 TEST=tests/language/vm/optimized_check_class_test.dart R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43014

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -1 line)			Patch
	M	runtime/vm/intermediate_language.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	tests/language/vm/optimized_check_class_test.dart	View		1 chunk	+70 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Florian Schneider

5 years, 11 months ago (2015-01-20 16:00:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r43014 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages