dart2js: use model in native emitter.

dart2js: use model in native emitter.

R=sra@google.com, zarah@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43064

[floitsch, 2015-01-19 16:43:09]

floitsch@google.com changed reviewers:
+ sra@google.com, zarah@google.com

[floitsch, 2015-01-20 20:30:35]

Updated the description to reflect that I want to commit this.
When I wrote "not completely done" I meant the transition. Not this CL.

[sra1, 2015-01-21 06:27:06]

LGTM if custom elements that are defined as a mixin application are impossible
or were possible but broken.

https://chromiumcodereview.appspot.com/859843002/diff/20001/pkg/compiler/lib/...
File pkg/compiler/lib/src/js_emitter/model.dart (right):

https://chromiumcodereview.appspot.com/859843002/diff/20001/pkg/compiler/lib/...
pkg/compiler/lib/src/js_emitter/model.dart:216: isNative: false);
I believe that you can create a custom element that is simply a mixin
application.

[zarah, 2015-01-21 08:42:58]

LGTM

[floitsch, 2015-01-21 12:24:23]

On 2015/01/21 06:27:06, sra1 wrote:
> LGTM if custom elements that are defined as a mixin application are impossible
> or were possible but broken.
Could you please help me test this?
What existing tests should I adapt to make sure I have this covered?

> 
>
https://chromiumcodereview.appspot.com/859843002/diff/20001/pkg/compiler/lib/...
> File pkg/compiler/lib/src/js_emitter/model.dart (right):
> 
>
https://chromiumcodereview.appspot.com/859843002/diff/20001/pkg/compiler/lib/...
> pkg/compiler/lib/src/js_emitter/model.dart:216: isNative: false);
> I believe that you can create a custom element that is simply a mixin
> application.

[sra1, 2015-01-21 18:38:29]

On 2015/01/21 12:24:23, floitsch wrote:
> On 2015/01/21 06:27:06, sra1 wrote:
> > LGTM if custom elements that are defined as a mixin application are
impossible
> > or were possible but broken.
> Could you please help me test this?
> What existing tests should I adapt to make sure I have this covered?

html/custom_elements_test.{dart,html}

I think we are safe. The constraints on having the named constructor will save
us.
A registered class C needs to have a C.created() constructor.  That constructor
is stored in some special metadata and registration will fail if it is not
found.
I don't think we can create a C.created() constructor via

    class C = HtmlElement with Mixin;

One thing to check would be does the Element model for the MixinApplication in
the test think it is native?

> 
> > 
> >
>
https://chromiumcodereview.appspot.com/859843002/diff/20001/pkg/compiler/lib/...
> > File pkg/compiler/lib/src/js_emitter/model.dart (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/859843002/diff/20001/pkg/compiler/lib/...
> > pkg/compiler/lib/src/js_emitter/model.dart:216: isNative: false);
> > I believe that you can create a custom element that is simply a mixin
> > application.

[floitsch, 2015-01-22 10:23:20]

On 2015/01/21 18:38:29, sra1 wrote:
> On 2015/01/21 12:24:23, floitsch wrote:
> > On 2015/01/21 06:27:06, sra1 wrote:
> > > LGTM if custom elements that are defined as a mixin application are
> impossible
> > > or were possible but broken.
> > Could you please help me test this?
> > What existing tests should I adapt to make sure I have this covered?
> 
> html/custom_elements_test.{dart,html}
> 
> I think we are safe. The constraints on having the named constructor will save
> us.
> A registered class C needs to have a C.created() constructor.  That
constructor
> is stored in some special metadata and registration will fail if it is not
> found.
> I don't think we can create a C.created() constructor via
> 
>     class C = HtmlElement with Mixin;
> 
> One thing to check would be does the Element model for the MixinApplication in
> the test think it is native?
It doesn't.
> 
> > 
> > > 
> > >
> >
>
https://chromiumcodereview.appspot.com/859843002/diff/20001/pkg/compiler/lib/...
> > > File pkg/compiler/lib/src/js_emitter/model.dart (right):
> > > 
> > >
> >
>
https://chromiumcodereview.appspot.com/859843002/diff/20001/pkg/compiler/lib/...
> > > pkg/compiler/lib/src/js_emitter/model.dart:216: isNative: false);
> > > I believe that you can create a custom element that is simply a mixin
> > > application.

[floitsch, 2015-01-22 10:23:59]

Committed patchset #2 (id:20001) manually as 43064 (presubmit successful).