Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 859043003: add basic constructor that doesn't take BarbackSettings (Closed)

Created:
5 years, 11 months ago by jakemac
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/static-init.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : format + remove barback from transformer test #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M lib/transformer.dart View 1 2 4 chunks +14 lines, -11 lines 0 comments Download
M test/transformer_test.dart View 1 2 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jakemac
Allows for easier testing and integration with other transformers (like Polymer).
5 years, 11 months ago (2015-01-20 17:51:02 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years, 11 months ago (2015-01-20 20:54:02 UTC) #3
jakemac
5 years, 11 months ago (2015-01-20 21:04:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
9aae9e86175f56eae40ed877503900e552c9882f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698