Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 858833002: Add server options. (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, Johnni Winther, lukechurch
Target Ref:
refs/remotes/trunk
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Move Options to own library. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -12 lines) Patch
M dart/pkg/dart2js_incremental/lib/server.dart View 1 2 chunks +10 lines, -12 lines 0 comments Download
A dart/pkg/dart2js_incremental/lib/src/options.dart View 1 1 chunk +134 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ahe
https://codereview.chromium.org/858833002/diff/1/dart/pkg/dart2js_incremental/lib/server.dart File dart/pkg/dart2js_incremental/lib/server.dart (right): https://codereview.chromium.org/858833002/diff/1/dart/pkg/dart2js_incremental/lib/server.dart#newcode294 dart/pkg/dart2js_incremental/lib/server.dart:294: serve that file instead. Not implemented yet.
5 years, 11 months ago (2015-01-19 09:32:22 UTC) #2
kasperl
LGTM. https://codereview.chromium.org/858833002/diff/1/dart/pkg/dart2js_incremental/lib/server.dart File dart/pkg/dart2js_incremental/lib/server.dart (right): https://codereview.chromium.org/858833002/diff/1/dart/pkg/dart2js_incremental/lib/server.dart#newcode162 dart/pkg/dart2js_incremental/lib/server.dart:162: class Options { Consider having this in a ...
5 years, 11 months ago (2015-01-19 09:37:27 UTC) #3
ahe
Thank you, Kasper! https://codereview.chromium.org/858833002/diff/1/dart/pkg/dart2js_incremental/lib/server.dart File dart/pkg/dart2js_incremental/lib/server.dart (right): https://codereview.chromium.org/858833002/diff/1/dart/pkg/dart2js_incremental/lib/server.dart#newcode162 dart/pkg/dart2js_incremental/lib/server.dart:162: class Options { On 2015/01/19 09:37:27, ...
5 years, 11 months ago (2015-01-19 10:23:08 UTC) #4
ahe
5 years, 11 months ago (2015-01-19 10:24:52 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 42983 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698