Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 858593003: Compute new targets for dynamic call sites eagerly. (Closed)

Created:
5 years, 11 months ago by herhut
Modified:
5 years, 11 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Compute new targets for dynamic call sites eagerly. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=42985

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -27 lines) Patch
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 2 chunks +24 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
herhut
This ensures that the side-effecting update of the targets is complete before new types are ...
5 years, 11 months ago (2015-01-19 10:39:42 UTC) #1
karlklose
https://codereview.chromium.org/858593003/diff/1/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart File pkg/compiler/lib/src/inferrer/type_graph_nodes.dart (right): https://codereview.chromium.org/858593003/diff/1/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart#newcode916 pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:916: }).toList()); As discussed offline, move the graph update out ...
5 years, 11 months ago (2015-01-19 11:23:40 UTC) #2
herhut
5 years, 11 months ago (2015-01-19 11:35:56 UTC) #4
karlklose
LGTM.
5 years, 11 months ago (2015-01-19 11:42:43 UTC) #5
herhut
5 years, 11 months ago (2015-01-19 11:46:15 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as 42985 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698