Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 858573002: Implement await and async for the js-ast. (Closed)

Created:
5 years, 11 months ago by sigurdm
Modified:
5 years, 11 months ago
Reviewers:
asgerf, floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Implement await and async for the js-ast. Implementing a new expression 'await e' in the js mini-parser and printer. Implementing async, async*, sync* function body modifiers. Also implementing while, do, switch, case, labelled statement in the js mini parser. This is in preparation for an await-desugaring transformation on the js ast. BUG= R=asgerf@google.com, floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=42999

Patch Set 1 #

Total comments: 4

Patch Set 2 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -33 lines) Patch
M pkg/compiler/lib/src/js/builder.dart View 1 6 chunks +90 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/js/nodes.dart View 5 chunks +35 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js/printer.dart View 1 8 chunks +33 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js/template.dart View 5 chunks +47 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/js_parser_statements_test.dart View 1 4 chunks +65 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/js_parser_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sigurdm
5 years, 11 months ago (2015-01-16 15:08:56 UTC) #2
floitsch
LGTM, but I would like to have Asger's opinion, too.
5 years, 11 months ago (2015-01-16 15:31:13 UTC) #4
asgerf
LGTM with some quick fixes. https://codereview.chromium.org/858573002/diff/1/pkg/compiler/lib/src/js/builder.dart File pkg/compiler/lib/src/js/builder.dart (right): https://codereview.chromium.org/858573002/diff/1/pkg/compiler/lib/src/js/builder.dart#newcode1265 pkg/compiler/lib/src/js/builder.dart:1265: acceptCategory(COLON); I think this ...
5 years, 11 months ago (2015-01-16 16:23:26 UTC) #5
sigurdm
Thanks for the review https://codereview.chromium.org/858573002/diff/1/pkg/compiler/lib/src/js/builder.dart File pkg/compiler/lib/src/js/builder.dart (right): https://codereview.chromium.org/858573002/diff/1/pkg/compiler/lib/src/js/builder.dart#newcode1265 pkg/compiler/lib/src/js/builder.dart:1265: acceptCategory(COLON); On 2015/01/16 16:23:26, asgerf ...
5 years, 11 months ago (2015-01-20 07:54:56 UTC) #6
sigurdm
5 years, 11 months ago (2015-01-20 08:10:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42999 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698