Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Issue 85853002: Print events only to the console and never to the DOM (Closed)

Created:
7 years ago by kustermann
Modified:
7 years ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Print events only to the console and never to the DOM IE9 does not have a console, so events were printed to the DOM. But since we get all events anyway when using the browser controller, there is no need to print it to the DOM. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=30630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M dart/tools/testing/dart/test_controller.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kustermann
7 years ago (2013-11-25 14:17:40 UTC) #1
ricow1
lgtm
7 years ago (2013-11-25 14:33:26 UTC) #2
kustermann
7 years ago (2013-11-25 14:35:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30630 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698