Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 85813002: Revert "Revert "Build new IR for functions returning a constant."" (Closed)

Created:
7 years ago by lukas
Modified:
7 years ago
Reviewers:
ngeoffray, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Revert "Build new IR for functions returning a constant."" R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=30632

Patch Set 1 #

Patch Set 2 : stop building IR for a block after emitting a return #

Patch Set 3 : #

Patch Set 4 : feedback by kasper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+895 lines, -128 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 3 chunks +5 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart2jslib.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 chunk +0 lines, -1 line 0 comments Download
A sdk/lib/_internal/compiler/implementation/inferrer/ir_type_inferrer.dart View 1 2 3 1 chunk +86 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart View 3 chunks +8 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
A sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart View 1 2 3 1 chunk +328 lines, -0 lines 0 comments Download
A sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart View 1 2 3 1 chunk +74 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/source_map_builder.dart View 1 chunk +29 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 11 chunks +124 lines, -98 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 1 chunk +26 lines, -16 lines 0 comments Download
A sdk/lib/_internal/compiler/implementation/ssa/from_ir_builder.dart View 1 1 chunk +128 lines, -0 lines 0 comments Download
A sdk/lib/_internal/compiler/implementation/ssa/from_ir_inliner.dart View 1 chunk +76 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/ssa.dart View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
lukas
Patch Set 2: stop emitting IR after 'return' in a block, cleanups in ir_type_inferrer. Patch ...
7 years ago (2013-11-25 14:50:23 UTC) #1
ngeoffray
LGTM
7 years ago (2013-11-25 14:54:24 UTC) #2
lukas
7 years ago (2013-11-25 15:02:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r30632 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698