Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 85783002: Bailout on array optimizations if the array might escape to reflection land. (Closed)

Created:
7 years ago by ngeoffray
Modified:
7 years ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Bailout on array optimizations if the array might escape to reflection land. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=30629

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/array_tracing_mirror_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download
A tests/lib/mirrors/array_tracing2_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A tests/lib/mirrors/array_tracing3_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download
A tests/lib/mirrors/array_tracing_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years ago (2013-11-25 13:39:37 UTC) #1
kasperl
LGTM.
7 years ago (2013-11-25 13:42:32 UTC) #2
ngeoffray
7 years ago (2013-11-25 14:00:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30629 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698