Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 8574075: Fix prototype of Dart_Initialize. (Closed)

Created:
9 years, 1 month ago by siva
Modified:
9 years, 1 month ago
Reviewers:
vsm, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix prototype of Dart_Initialize. Committed: https://code.google.com/p/dart/source/detail?r=1635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M bin/gen_snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M bin/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M include/dart_api.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
9 years, 1 month ago (2011-11-17 21:38:55 UTC) #1
srdjan
LGTM
9 years, 1 month ago (2011-11-17 21:45:52 UTC) #2
vsm
9 years, 1 month ago (2011-11-17 21:55:17 UTC) #3
LGTM

We can keep an eye on the dartium bot - if it fails, I'll add the const_cast
there as well.

Powered by Google App Engine
This is Rietveld 408576698