Add num.parse.

Add num.parse.

The implementation is still primitive: It calls int.parse, then double.parse, and then fails if it hasn't found a result yet.

BUG= http://dartbug.com/8237
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30624

Committed: https://code.google.com/p/dart/source/detail?r=30663

[Lasse Reichstein Nielsen, 2013-11-25 12:37:40]

https://codereview.chromium.org/85633003/diff/50001/runtime/lib/double_patch....
File runtime/lib/double_patch.dart (right):

https://codereview.chromium.org/85633003/diff/50001/runtime/lib/double_patch....
runtime/lib/double_patch.dart:49: if (result.isNaN) return NAN;
This seems like an unnecessary hack.

The NaNs should be considered equal by Instance::IsIdenticalTo, which is what
the native Identical_comparison uses. Apparently something else happens instead.

[floitsch, 2013-11-25 12:50:53]

LGTM.

https://codereview.chromium.org/85633003/diff/50001/runtime/lib/double_patch....
File runtime/lib/double_patch.dart (right):

https://codereview.chromium.org/85633003/diff/50001/runtime/lib/double_patch....
runtime/lib/double_patch.dart:49: if (result.isNaN) return NAN;
On 2013/11/25 12:37:40, Lasse Reichstein Nielsen wrote:
> This seems like an unnecessary hack.
> 
> The NaNs should be considered equal by Instance::IsIdenticalTo, which is what
> the native Identical_comparison uses. Apparently something else happens
instead.

completely agree.
Please file a bug for the VM so that this can't happen for other NANs.

https://codereview.chromium.org/85633003/diff/50001/sdk/lib/core/int.dart
File sdk/lib/core/int.dart (right):

https://codereview.chromium.org/85633003/diff/50001/sdk/lib/core/int.dart#new...
sdk/lib/core/int.dart:249: * If no [radix] is given then it defaults to 16 if
the string starts
.. it defaults to 10, unless the string starts with "0x", "-0x" or "+0x" in
which case radix is set to "16" and the "0x" is ignored.

?

https://codereview.chromium.org/85633003/diff/50001/sdk/lib/core/num.dart
File sdk/lib/core/num.dart (right):

https://codereview.chromium.org/85633003/diff/50001/sdk/lib/core/num.dart#new...
sdk/lib/core/num.dart:366: * The input string should be either one accepted by
[int.parse] (with no
won't work in dartdoc: []()

Not sure if much better, but here is my attempt.

The method first tries to read the [input] as integer (similar to [int.parse]
without radix). If that fails, it tries to parse the [input] as double (as in
[double.parse]). If that fails, too, it invokes [onError] with [input].

If no [onError] is supplied, it defaults to a function that throws a
[FormatException].

https://codereview.chromium.org/85633003/diff/50001/sdk/lib/core/num.dart#new...
sdk/lib/core/num.dart:374: * If no [onError] is suppled, a [FormatException] is
thrown.
supplied

https://codereview.chromium.org/85633003/diff/50001/sdk/lib/core/num.dart#new...
sdk/lib/core/num.dart:376: * For any number `n`, this function satisfies `n ==
num.parse(n.toString())`.
any number `n`, not NaN, ...

or use identical(n, num.parse(n.toString()))

[Lasse Reichstein Nielsen, 2013-11-25 13:05:15]

Added issue http://dartbug.com/15293 for the VM.

https://codereview.chromium.org/85633003/diff/50001/sdk/lib/core/int.dart
File sdk/lib/core/int.dart (right):

https://codereview.chromium.org/85633003/diff/50001/sdk/lib/core/int.dart#new...
sdk/lib/core/int.dart:249: * If no [radix] is given then it defaults to 16 if
the string starts
Sounds much better. Done!

https://codereview.chromium.org/85633003/diff/50001/sdk/lib/core/num.dart
File sdk/lib/core/num.dart (right):

https://codereview.chromium.org/85633003/diff/50001/sdk/lib/core/num.dart#new...
sdk/lib/core/num.dart:366: * The input string should be either one accepted by
[int.parse] (with no
That is better. Done.

https://codereview.chromium.org/85633003/diff/50001/sdk/lib/core/num.dart#new...
sdk/lib/core/num.dart:374: * If no [onError] is suppled, a [FormatException] is
thrown.
Replaced by your wording above.

https://codereview.chromium.org/85633003/diff/50001/sdk/lib/core/num.dart#new...
sdk/lib/core/num.dart:376: * For any number `n`, this function satisfies `n ==
num.parse(n.toString())`.
Used identical. That's what the test tests too.

[Lasse Reichstein Nielsen, 2013-11-25 13:09:15]

Committed patchset #5 manually as r30624 (presubmit successful).

[Lasse Reichstein Nielsen, 2013-11-26 08:03:58]

Nicolas, please take a look. It fails for dart2js on IE9 only.

[Lasse Reichstein Nielsen, 2013-11-26 08:44:48]

Committed patchset #10 manually as r30663 (presubmit successful).