Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 85633002: Handle parenthesized expression in type promotion. (Closed)

Created:
7 years ago by Johnni Winther
Modified:
7 years ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle parenthesized expression in type promotion. BUG=http://dartbug.com/14363 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=30660

Patch Set 1 #

Patch Set 2 : Fix comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -8 lines) Patch
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 1 4 chunks +25 lines, -7 lines 0 comments Download
M tests/language/type_promotion_closure_test.dart View 3 chunks +28 lines, -0 lines 0 comments Download
M tests/language/type_promotion_logical_and_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/type_promotion_parameter_test.dart View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
7 years ago (2013-11-25 12:00:17 UTC) #1
karlklose
LGTM.
7 years ago (2013-11-25 13:50:46 UTC) #2
Johnni Winther
7 years ago (2013-11-26 07:57:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r30660 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698