File watching compiler.

File watching compiler.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43004

[ahe, 2015-01-19 15:31:56]

ahe@google.com changed reviewers:
+ kasperl@google.com

[ahe, 2015-01-19 15:31:56]

Next step: integrate this into server.dart.

[kasperl, 2015-01-20 10:23:00]

LGTM.

https://codereview.chromium.org/855953002/diff/1/dart/pkg/dart2js_incremental...
File dart/pkg/dart2js_incremental/lib/compiler.dart (right):

https://codereview.chromium.org/855953002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/compiler.dart:43: Future/*<String |
List<int>>*/ inputProvider(Uri uri) {
I probably wouldn't bother with the fancy "type in comments" here since you're
just wrapping the provider method from diagnosticHandler.

https://codereview.chromium.org/855953002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/compiler.dart:64: 
Only one newline.

https://codereview.chromium.org/855953002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/compiler.dart:66: int updateCount = 1;
0 and then use prefix ++?

https://codereview.chromium.org/855953002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/compiler.dart:88: /// Output provider which
collect output in [output].
collect -> collects

https://codereview.chromium.org/855953002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/compiler.dart:98: String operator[] (String
key) => output[key];
I'd remove the space between [] and (.

https://codereview.chromium.org/855953002/diff/1/dart/pkg/dart2js_incremental...
File dart/pkg/dart2js_incremental/lib/watcher.dart (right):

https://codereview.chromium.org/855953002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/watcher.dart:30:
_onFileSystemEvent(FileSystemEvent event) {
void?

[ahe, 2015-01-20 10:45:52]

Thank you, Kasper!

https://codereview.chromium.org/855953002/diff/1/dart/pkg/dart2js_incremental...
File dart/pkg/dart2js_incremental/lib/compiler.dart (right):

https://codereview.chromium.org/855953002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/compiler.dart:43: Future/*<String |
List<int>>*/ inputProvider(Uri uri) {
On 2015/01/20 10:23:00, kasperl wrote:
> I probably wouldn't bother with the fancy "type in comments" here since you're
> just wrapping the provider method from diagnosticHandler.

Done.

https://codereview.chromium.org/855953002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/compiler.dart:64: 
On 2015/01/20 10:23:00, kasperl wrote:
> Only one newline.

Done.

https://codereview.chromium.org/855953002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/compiler.dart:66: int updateCount = 1;
On 2015/01/20 10:23:00, kasperl wrote:
> 0 and then use prefix ++?

Done.

https://codereview.chromium.org/855953002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/compiler.dart:88: /// Output provider which
collect output in [output].
On 2015/01/20 10:23:00, kasperl wrote:
> collect -> collects

Done.

https://codereview.chromium.org/855953002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/compiler.dart:98: String operator[] (String
key) => output[key];
On 2015/01/20 10:23:00, kasperl wrote:
> I'd remove the space between [] and (.

Done.

https://codereview.chromium.org/855953002/diff/1/dart/pkg/dart2js_incremental...
File dart/pkg/dart2js_incremental/lib/watcher.dart (right):

https://codereview.chromium.org/855953002/diff/1/dart/pkg/dart2js_incremental...
dart/pkg/dart2js_incremental/lib/watcher.dart:30:
_onFileSystemEvent(FileSystemEvent event) {
On 2015/01/20 10:23:00, kasperl wrote:
> void?

Done.

[ahe, 2015-01-20 10:47:13]

Committed patchset #3 (id:2) manually as 43004 (presubmit successful).