Issue 85593002: Make sure the SSA codegen visit constants used in a switch through the 'visitConstant' method, to e…

Issue 85593002: Make sure the SSA codegen visit constants used in a switch through the 'visitConstant' method, to e… (Closed)

Created:
7 years ago by ngeoffray

Modified:
7 years ago

Reviewers:
karlklose, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make sure the SSA codegen visit constants used in a switch through the 'visitConstant' method, to ensure they are registered to the compile time constant handler. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=30627

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -17 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	4 chunks	+0 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1	1 chunk	+19 lines, -9 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
A	tests/language/switch8_test.dart	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/85593002/diff/1/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right): https://codereview.chromium.org/85593002/diff/1/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart#newcode699 sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:699: generateStatements(info.statements[info.statements.length - 1]); info.statements.last?

7 years ago (2013-11-25 11:35:19 UTC) #2

ngeoffray

Thanks Kasper. https://codereview.chromium.org/85593002/diff/1/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right): https://codereview.chromium.org/85593002/diff/1/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart#newcode699 sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:699: generateStatements(info.statements[info.statements.length - 1]); On 2013/11/25 11:35:20, kasperl ...

7 years ago (2013-11-25 13:40:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r30627 (presubmit successful).

Expand Messages | Collapse Messages