Add CHANNEL to tools/VERSION

Add CHANNEL to tools/VERSION

R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30620

[ricow1, 2013-11-25 11:35:42]

LGTM, but we need to be careful when we do the next push, you should allow bob
to take a look as well

[kustermann, 2013-11-25 12:51:44]

@bob: Just FYI.

[kustermann, 2013-11-25 12:52:05]

Committed patchset #2 manually as r30620 (presubmit successful).

[Bob Nystrom, 2013-11-25 17:41:59]

https://codereview.chromium.org/85553002/diff/50001/dart/tools/VERSION
File dart/tools/VERSION (right):

https://codereview.chromium.org/85553002/diff/50001/dart/tools/VERSION#newcode5
dart/tools/VERSION:5: PATCH 0
Does this affect the VERSION file in the SDK?

If so, can you take a look at sdk/lib/_internal/pub/lib/sdk.dart? That's the
code that parses that file. If it fails, we do have a test that will fail, so it
should let us know if it breaks, but it doesn't hurt to be proactive. :)

https://codereview.chromium.org/85553002/diff/50001/dart/tools/publish_barbac...
File dart/tools/publish_barback.py (right):

https://codereview.chromium.org/85553002/diff/50001/dart/tools/publish_barbac...
dart/tools/publish_barback.py:38: if (major == 0 and minor <= 1) or channel ==
'be':
If channel will reliably be set, you can just remove the major and minor
checking here.

https://codereview.chromium.org/85553002/diff/50001/dart/tools/publish_barbac...
dart/tools/publish_barback.py:66: constraint = '>=%d.%d.%d <%d.%d.0' % (major,
minor, build, major, minor + 1)
Hey Rico and Martin: until I know what actual numbering scheme the SDK will use,
this may not be correct. What's the status on that?

https://codereview.chromium.org/85553002/diff/50001/dart/tools/utils.py
File dart/tools/utils.py (right):

https://codereview.chromium.org/85553002/diff/50001/dart/tools/utils.py#newco...
dart/tools/utils.py:238: # TODO(kustermann/ricow): Add the channel to the
version string.
What would having the channel in the version name mean? Would there ever be two
versions where the only difference was the channel name, or is it always just
additional metadata?

[dgrove, 2013-11-26 00:21:25]

On 2013/11/25 11:35:42, ricow1 wrote:
> LGTM, but we need to be careful when we do the next push, you should allow bob
> to take a look as well

FYI - in r30653, I merged this into trunk. For channel, Bob and I chose "dev".

[kustermann, 2013-11-26 14:17:32]

https://codereview.chromium.org/85553002/diff/50001/dart/tools/VERSION
File dart/tools/VERSION (right):

https://codereview.chromium.org/85553002/diff/50001/dart/tools/VERSION#newcode5
dart/tools/VERSION:5: PATCH 0
On 2013/11/25 17:41:59, Bob Nystrom wrote:
> Does this affect the VERSION file in the SDK?
> 
> If so, can you take a look at sdk/lib/_internal/pub/lib/sdk.dart? That's the
> code that parses that file. If it fails, we do have a test that will fail, so
it
> should let us know if it breaks, but it doesn't hurt to be proactive. :)

It doesn't affect the dart-sdk/version file.

https://codereview.chromium.org/85553002/diff/50001/dart/tools/publish_barbac...
File dart/tools/publish_barback.py (right):

https://codereview.chromium.org/85553002/diff/50001/dart/tools/publish_barbac...
dart/tools/publish_barback.py:38: if (major == 0 and minor <= 1) or channel ==
'be':
On 2013/11/25 17:41:59, Bob Nystrom wrote:
> If channel will reliably be set, you can just remove the major and minor
> checking here.

I thought about removing it, but it doesn't hurt if we keep it and this change
isn't in all channels (though we'll merge it over at some point).

https://codereview.chromium.org/85553002/diff/50001/dart/tools/publish_barbac...
dart/tools/publish_barback.py:66: constraint = '>=%d.%d.%d <%d.%d.0' % (major,
minor, build, major, minor + 1)
On 2013/11/25 17:41:59, Bob Nystrom wrote:
> Hey Rico and Martin: until I know what actual numbering scheme the SDK will
use,
> this may not be correct. What's the status on that?

I think we all agree that having semantic versions is the right way to go. We
just need to work out the details -- but I don't think we should rush.

https://codereview.chromium.org/85553002/diff/50001/dart/tools/utils.py
File dart/tools/utils.py (right):

https://codereview.chromium.org/85553002/diff/50001/dart/tools/utils.py#newco...
dart/tools/utils.py:238: # TODO(kustermann/ricow): Add the channel to the
version string.
On 2013/11/25 17:41:59, Bob Nystrom wrote:
> What would having the channel in the version name mean? Would there ever be
two
> versions where the only difference was the channel name, or is it always just
> additional metadata?

We haven't decided anything, I just put in this TODO to not forget about it.

I think it's beneficial for users to be able to figure out if their SDK is
coming from be/dev or stable channel.