Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 854633005: Fix incorrect handling of closing stderr on Windows (Closed)

Created:
5 years, 11 months ago by Søren Gjesse
Modified:
5 years, 11 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix incorrect handling of closing stderr on Windows BUG=http://dartbug.com/22088 R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=43060

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M runtime/bin/file_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
5 years, 11 months ago (2015-01-21 15:23:39 UTC) #1
kustermann
lgtm
5 years, 11 months ago (2015-01-22 09:04:05 UTC) #2
Søren Gjesse
5 years, 11 months ago (2015-01-22 09:25:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43060 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698