Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 854493002: Have the analysis server not send error notifications when NO_ERROR_NOTIFICATION has been set to tr… (Closed)

Created:
5 years, 11 months ago by jwren
Modified:
5 years, 11 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Have the analysis server not send error notifications when NO_ERROR_NOTIFICATION has been set to true. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=42851

Patch Set 1 #

Patch Set 2 : update flag description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 4 chunks +9 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
jwren
5 years, 11 months ago (2015-01-14 00:13:02 UTC) #2
scheglov
LGTM
5 years, 11 months ago (2015-01-14 01:15:50 UTC) #3
jwren
5 years, 11 months ago (2015-01-14 04:00:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42851 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698