Catch and report exceptions in computers.

Catch and report exceptions in computers.

So, they will not cause the server crash anymore.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=42841

[Brian Wilkerson, 2015-01-13 20:57:37]

LGTM

https://codereview.chromium.org/854443002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/854443002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:677: void
sendServerErrorNotification(exception, stackTrace, {bool fatal: true}) {
It looks like "false" is more common than "true". Given that this controls the
value passed in the notification rather than whether server will shut down, it
might be better to reverse the default.

[scheglov, 2015-01-13 21:13:51]

https://codereview.chromium.org/854443002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/854443002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:677: void
sendServerErrorNotification(exception, stackTrace, {bool fatal: true}) {
On 2015/01/13 20:57:37, Brian Wilkerson wrote:
> It looks like "false" is more common than "true". Given that this controls the
> value passed in the notification rather than whether server will shut down, it
> might be better to reverse the default.

Done.

[scheglov, 2015-01-13 21:14:14]

Committed patchset #2 (id:20001) manually as 42841 (presubmit successful).