Issue 853943004: Make fetch_observatory_deps depend on packages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 853943004: Make fetch_observatory_deps depend on packages (Closed)

Created:
5 years, 11 months ago by Cutch

Modified:
5 years, 11 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Make fetch_observatory_deps depend on packages BUG= Committed: https://code.google.com/p/dart/source/detail?r=42926

Patch Set 1 #

Total comments: 1

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	runtime/observatory/observatory.gypi	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

Committed patchset #1 (id:1) manually as 42926 (presubmit successful).

5 years, 11 months ago (2015-01-15 19:29:15 UTC) #3

ricow1

5 years, 11 months ago (2015-01-15 19:31:37 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/853943004/diff/1/runtime/observatory/observat...
File runtime/observatory/observatory.gypi (right):

https://codereview.chromium.org/853943004/diff/1/runtime/observatory/observat...
runtime/observatory/observatory.gypi:23: '../../tools/observatory_tool.py',
You need:
'<(SHARED_INTERMEDIATE_DIR)/packages.stamp',

here for this to work

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages