Issue 85373002: Use EV_ONESHOT in eventhandler on Mac OS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 85373002: Use EV_ONESHOT in eventhandler on Mac OS. (Closed)

Created:
7 years ago by Anders Johnsen

Modified:
7 years ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use EV_ONESHOT in eventhandler on Mac OS. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=30611

Patch Set 2 : epoll->kqueue #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -7 lines)			Patch
	M	runtime/bin/eventhandler_macos.cc	View	1	3 chunks	+22 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

https://codereview.chromium.org/85373002/diff/1/runtime/bin/eventhandler_macos.cc File runtime/bin/eventhandler_macos.cc (right): https://codereview.chromium.org/85373002/diff/1/runtime/bin/eventhandler_macos.cc#newcode360 runtime/bin/eventhandler_macos.cc:360: // Event not handled, re-add to epoll. epoll -> ...

7 years ago (2013-11-25 08:53:20 UTC) #2

Anders Johnsen

PTAL https://codereview.chromium.org/85373002/diff/1/runtime/bin/eventhandler_macos.cc File runtime/bin/eventhandler_macos.cc (right): https://codereview.chromium.org/85373002/diff/1/runtime/bin/eventhandler_macos.cc#newcode360 runtime/bin/eventhandler_macos.cc:360: // Event not handled, re-add to epoll. On ...

7 years ago (2013-11-25 08:54:06 UTC) #3

Anders Johnsen

7 years ago (2013-11-25 08:58:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r30611 (presubmit successful).

Expand Messages | Collapse Messages

Issue 85373002: Use EV_ONESHOT in eventhandler on Mac OS. (Closed)

Description

Patch Set 1 #

Patch Set 2 : epoll->kqueue #

Messages