Issue 853613003: Optimize creation of ASCII strings in UTF-8 JSON parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 853613003: Optimize creation of ASCII strings in UTF-8 JSON parser. (Closed)

Created:
5 years, 11 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 11 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Optimize creation of ASCII strings in UTF-8 JSON parser. Recognize that the string is ASCII only during scanning, and just use String.fromCharCodes directly, instead of interpreting as UTF-8 first. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=42857

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -13 lines)			Patch
	M	runtime/lib/convert_patch.dart	View	1	9 chunks	+22 lines, -13 lines	0 comments	Download

Total messages: 4 (1 generated)

Lasse Reichstein Nielsen

5 years, 11 months ago (2015-01-14 10:23:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 42857 (presubmit successful).