Issue 8523036: Report an error when Dart_ListGetAsBytes does not get an integer list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8523036: Report an error when Dart_ListGetAsBytes does not get an integer list. (Closed)

Created:
9 years, 1 month ago by siva

Modified:
9 years, 1 month ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Report an error when Dart_ListGetAsBytes does not get an integer list. Committed: https://code.google.com/p/dart/source/detail?r=1585

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	vm/dart_api_impl.cc	View		4 chunks	+10 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

turnidge

lgtm, one small question. http://codereview.chromium.org/8523036/diff/1/vm/dart_api_impl.cc File vm/dart_api_impl.cc (right): http://codereview.chromium.org/8523036/diff/1/vm/dart_api_impl.cc#newcode1132 vm/dart_api_impl.cc:1132: "a list of integers", CURRENT_FUNC); ...

9 years, 1 month ago (2011-11-16 18:56:45 UTC) #2

siva

9 years, 1 month ago (2011-11-16 18:59:08 UTC) #3

http://codereview.chromium.org/8523036/diff/1/vm/dart_api_impl.cc
File vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8523036/diff/1/vm/dart_api_impl.cc#newcode1132
vm/dart_api_impl.cc:1132: "a list of integers", CURRENT_FUNC);
Our official type name is int, maybe I should re word it as "a list of int" what
do you think?

On 2011/11/16 18:56:45, turnidge wrote:
> I don't know if we capitalize Integer here or not.

Expand Messages | Collapse Messages