Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 852003003: yaml: reformat, fix README and homepage link, bump version (Closed)

Created:
5 years, 11 months ago by kevmoo
Modified:
5 years, 11 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/yaml.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

yaml: reformat, fix README and homepage link, bump version R=nweiz@google.com Committed: https://github.com/dart-lang/yaml/commit/2972862ee70e46db07dc94c68496071fb21e7e8e

Patch Set 1 #

Patch Set 2 : removed format tweaks #

Patch Set 3 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M README.md View 1 chunk +0 lines, -4 lines 0 comments Download
M codereview.settings View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/parser.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M pubspec.yaml View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kevmoo
5 years, 11 months ago (2015-01-14 19:02:04 UTC) #2
nweiz
I don't think the reformatting is good enough for this package to be worth the ...
5 years, 11 months ago (2015-01-14 19:18:08 UTC) #3
kevmoo
Removed reformat. Kept other tweaks. PTAL
5 years, 11 months ago (2015-01-17 22:50:14 UTC) #4
nweiz
lgtm
5 years, 11 months ago (2015-01-20 23:23:03 UTC) #5
kevmoo
5 years, 11 months ago (2015-01-21 00:20:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
2972862ee70e46db07dc94c68496071fb21e7e8e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698