Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 851683004: dart2js: register output units explicitly in the program builder. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
zarah
CC:
reviews_dartlang.org, kasperl
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: register output units explicitly in the program builder. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=42866

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/registry.dart View 1 2 chunks +18 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 11 months ago (2015-01-13 21:03:14 UTC) #2
zarah
LGTM
5 years, 11 months ago (2015-01-14 10:46:15 UTC) #3
floitsch
5 years, 11 months ago (2015-01-14 13:02:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42866 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698