Issue 851513002: Grow allocation in Zone::Realloc when possible.

Issue 851513002: Grow allocation in Zone::Realloc when possible. (Closed)

Created:
5 years, 11 months ago by koda

Modified:
5 years, 11 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Grow allocation in Zone::Realloc when possible. Typical success rate is 30-40% of calls to Realloc, which is used by GrowableArray. Typical total zone memory savings are ~3%. Committed: https://code.google.com/p/dart/source/detail?r=42788

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -10 lines)			Patch
	M	runtime/vm/zone.h	View	1 2 3	2 chunks	+36 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTMwC -ip https://codereview.chromium.org/851513002/diff/40001/runtime/vm/zone.h File runtime/vm/zone.h (right): https://codereview.chromium.org/851513002/diff/40001/runtime/vm/zone.h#newcode252 runtime/vm/zone.h:252: intptr_t new_len) { Please fix indentation. https://codereview.chromium.org/851513002/diff/40001/runtime/vm/zone.h#newcode256 ...

5 years, 11 months ago (2015-01-12 18:33:36 UTC) #2

koda

https://codereview.chromium.org/851513002/diff/40001/runtime/vm/zone.h File runtime/vm/zone.h (right): https://codereview.chromium.org/851513002/diff/40001/runtime/vm/zone.h#newcode252 runtime/vm/zone.h:252: intptr_t new_len) { On 2015/01/12 18:33:36, Ivan Posva wrote: ...

5 years, 11 months ago (2015-01-12 21:19:35 UTC) #3

koda

5 years, 11 months ago (2015-01-12 22:00:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as r42788 (presubmit successful).

Expand Messages | Collapse Messages