Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 851273002: Tweaks in the VM's typed_data implementations. (Closed)

Created:
5 years, 11 months ago by Florian Schneider
Modified:
5 years, 11 months ago
Reviewers:
zerny-google
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Tweaks in the VM's typed_data implementations. Moving the throw of RangeError out of the _throwRangeError helper may benefit LICM, since that block is now considered a method exit (and not part of a enclosing loop). _throwRangeError was not inlined because the call site was considered cold by invocation counters (most programs don't throw RangeError). Also, I renamed some misleading names in the optimizer. R=zerny@google.com Committed: https://code.google.com/p/dart/source/detail?r=42951

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -213 lines) Patch
M runtime/lib/typed_data.dart View 106 chunks +112 lines, -111 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 19 chunks +47 lines, -47 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 3 chunks +50 lines, -50 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 11 months ago (2015-01-16 10:42:35 UTC) #2
zerny-google
lgtm
5 years, 11 months ago (2015-01-16 11:15:58 UTC) #3
Florian Schneider
5 years, 11 months ago (2015-01-16 11:30:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r42951 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698