Issue 851253002: Reapply revert of "Make stdout/stderr async"

Issue 851253002: Reapply revert of "Make stdout/stderr async" (Closed)

Created:
5 years, 11 months ago by Søren Gjesse

Modified:
5 years, 11 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Reapply revert of "Make stdout/stderr async" This re-applies r42909 which was reverted in r42910 with a few fixes. TBR=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42953

Patch Set 1 #

Patch Set 2 : Changes to fix build-bot failures #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -224 lines)			Patch
M	pkg/analysis_server/lib/src/server/stdio_server.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/io_natives.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/stdio.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	runtime/bin/stdio.cc	View	1	1 chunk	+13 lines, -1 line	0 comments	Download
M	runtime/bin/stdio_linux.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	runtime/bin/stdio_macos.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/stdio_patch.dart	View		2 chunks	+8 lines, -15 lines	0 comments	Download
M	runtime/bin/stdio_win.cc	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/io_patch.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
D	sdk/lib/io/console.dart	View		1 chunk	+0 lines, -97 lines	0 comments	Download
M	sdk/lib/io/io.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/io/iolib_sources.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/io/stdio.dart	View		6 chunks	+62 lines, -8 lines	0 comments	Download
D	tests/standalone/io/console_script.dart	View		1 chunk	+0 lines, -31 lines	0 comments	Download
D	tests/standalone/io/console_test.dart	View		1 chunk	+0 lines, -27 lines	0 comments	Download
A	tests/standalone/io/stdio_nonblocking_script.dart	View		1 chunk	+34 lines, -0 lines	0 comments	Download
A +	tests/standalone/io/stdio_nonblocking_test.dart	View		2 chunks	+3 lines, -2 lines	0 comments	Download
A +	tests/standalone/io/stdout_stderr_non_blocking_test.dart	View		2 chunks	+5 lines, -5 lines	0 comments	Download
A	tests/standalone/io/stdout_stderr_terminal_test.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download
D	tests/standalone/io/stdout_test.dart	View		1 chunk	+0 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Committed patchset #2 (id:20001) manually as 42953 (presubmit successful).

5 years, 11 months ago (2015-01-16 13:35:57 UTC) #1

Søren Gjesse

Patch set #2 has the differences from what you have already reviewed.

5 years, 11 months ago (2015-01-16 13:36:54 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages