Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 850473002: MallocGrowableArray (Closed)

Created:
5 years, 11 months ago by koda
Modified:
5 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

MallocGrowableArray To be used where neither Dart nor zone allocation is suitable, such as ClassTable. Also add ASSERT_NOTNULL convenience macro for use in initializer lists. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=42819

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -38 lines) Patch
M runtime/platform/assert.h View 1 4 chunks +13 lines, -5 lines 0 comments Download
M runtime/vm/dart_entry_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/growable_array.h View 1 2 8 chunks +63 lines, -26 lines 0 comments Download
M runtime/vm/growable_array_test.cc View 5 chunks +18 lines, -5 lines 0 comments Download
M runtime/vm/zone.h View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
5 years, 11 months ago (2015-01-12 17:40:57 UTC) #1
siva
lgtm
5 years, 11 months ago (2015-01-13 00:16:31 UTC) #2
koda
5 years, 11 months ago (2015-01-13 16:40:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r42819 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698