Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 850333002: Revert "Revert "Make stdout/stderr async"" (Closed)

Created:
5 years, 11 months ago by Søren Gjesse
Modified:
5 years, 11 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert "Revert "Make stdout/stderr async"" This reverts commit r42909 TBR=ricow@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -225 lines) Patch
M pkg/analysis_server/lib/src/server/stdio_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/io_natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/stdio.h View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/stdio.cc View 1 chunk +1 line, -6 lines 0 comments Download
M runtime/bin/stdio_linux.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/bin/stdio_macos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/stdio_patch.dart View 2 chunks +15 lines, -8 lines 0 comments Download
M runtime/bin/stdio_win.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/io_patch.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A sdk/lib/io/console.dart View 1 chunk +97 lines, -0 lines 0 comments Download
M sdk/lib/io/io.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/io/iolib_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/io/stdio.dart View 6 chunks +8 lines, -62 lines 0 comments Download
A tests/standalone/io/console_script.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A + tests/standalone/io/console_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
D tests/standalone/io/stdio_nonblocking_script.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D tests/standalone/io/stdio_nonblocking_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/standalone/io/stdout_stderr_non_blocking_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/standalone/io/stdout_stderr_terminal_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
A tests/standalone/io/stdout_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
5 years, 11 months ago (2015-01-15 14:33:20 UTC) #1
Søren Gjesse
Committed patchset #1 (id:1) manually as 42910 (presubmit successful).
5 years, 11 months ago (2015-01-15 14:33:50 UTC) #2
ricow1
5 years, 11 months ago (2015-01-15 14:33:56 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698