Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 850053005: Disables printing a version string to the console for GN build. (Closed)

Created:
5 years, 11 months ago by zra
Modified:
5 years, 11 months ago
Reviewers:
ricow1, Ivan Posva
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Visibility:
Public.

Description

Disables printing a version string to the console for GN build. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=43041

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M runtime/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/make_version.py View 4 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
zra
For dartbug.com/22119 for Mojo.
5 years, 11 months ago (2015-01-20 23:17:07 UTC) #2
ricow1
lgtm
5 years, 11 months ago (2015-01-21 07:18:39 UTC) #3
zra
5 years, 11 months ago (2015-01-21 15:18:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r43041 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698