Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 85003003: Fix ddbg completers (Closed)

Created:
7 years ago by hausner
Modified:
7 years ago
Reviewers:
iposva, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix ddbg completers The debugger tool now depends on command completers being executed synchronously, so create completes with the proper constructor. This fixes occasional assertions that an isolate is paused when stepping. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=30639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/ddbg.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
7 years ago (2013-11-25 17:31:04 UTC) #1
hausner
Volunteering another review victim :-)
7 years ago (2013-11-25 18:43:35 UTC) #2
Ivan Posva
LGTM -ip
7 years ago (2013-11-25 18:47:01 UTC) #3
hausner
7 years ago (2013-11-25 19:26:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r30639 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698