add local parameter info to completion suggestions

add local parameter info to completion suggestions

BUG=
R=paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42894

[danrubel, 2015-01-14 05:38:35]

danrubel@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2015-01-14 17:48:35]

lgtm

https://codereview.chromium.org/850003002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/completion/local_computer.dart
(right):

https://codereview.chromium.org/850003002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/local_computer.dart:216:
returnType: NO_RETURN_TYPE,
Nit: it seems unfortunate to me that we have to indicate the absence of a return
type so deliberately--it would be nice if simply leaving out the "returnType"
parameter meant "no return type".  But I can't think of a good way to make that
work, since as I understand it we need a returnType of void to be turned into
"dynamic".

[danrubel, 2015-01-15 02:26:27]

https://codereview.chromium.org/850003002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/completion/local_computer.dart
(right):

https://codereview.chromium.org/850003002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/local_computer.dart:216:
returnType: NO_RETURN_TYPE,
On 2015/01/14 17:48:35, Paul Berry wrote:
> Nit: it seems unfortunate to me that we have to indicate the absence of a
return
> type so deliberately--it would be nice if simply leaving out the "returnType"
> parameter meant "no return type".  But I can't think of a good way to make
that
> work, since as I understand it we need a returnType of void to be turned into
> "dynamic".

I agree and don't like this either but could not find a better way. I'll ponder
it some more and see if I can refactor this in a subsequent CL.

[danrubel, 2015-01-15 02:26:51]

Committed patchset #2 (id:20001) manually as 42894 (presubmit successful).