Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 84993004: Add more tests of num.parse. (Closed)

Created:
7 years ago by Lasse Reichstein Nielsen
Modified:
7 years ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : More negative tests. #

Patch Set 3 : Remove unnecessary {} #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -6 lines) Patch
M tests/corelib/num_parse_test.dart View 1 2 3 chunks +85 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years ago (2013-11-25 13:32:22 UTC) #1
floitsch
LGTM.
7 years ago (2013-11-25 13:48:41 UTC) #2
Lasse Reichstein Nielsen
7 years ago (2013-11-25 13:50:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r30628 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698